On 3/6/24 11:19 AM, John Fastabend wrote:
Yonghong Song wrote:
One of our internal services started to use sk_msg program and currently
it used existing prog attach/detach2 as demonstrated in selftests.
But attach/detach of all other bpf programs are based on bpf_link.
Consistent attach/detach APIs for all programs will make things easy to
undersand and less error prone. So this patch added bpf_link
support for BPF_PROG_TYPE_SK_MSG.
I marked the patch as RFC as not all functionality are covered
by tests yet, e.g. update_prog(). Maybe somebody can suggest
an existing test which I can look into.
Or maybe some other tests need to be added as well.
Agree this was missing it will be nice to get this merged. The links
are much nicer to deal with.
Agree that bpf_link is better as proved by other cases. It would be great
if you can take a look at the patch set and let me any issues, missing cases,
missing tests, etc. Thanks!
