Hi, On Tuesday, March 5, 2024 4:05:32 PM IST Quentin Monnet wrote: > [...] > Yes, we should remove this second condition too for files. Running > "is_bpffs(name)" makes no sense as we know we'll have an error at this > point. > > What we could do to improve the current code, however, is returning an > error from mount_bpffs_for_pin() if the file exists, rather than > mounting the bpffs and waiting for bpf_obj_pin() to return the error. > This would prevent bpftool from mounting the bpffs when we already know > the operation will fail. > > Quentin Sorry for the delay in replying. I have got a patch ready and have incorporated this as well. I need to run a few tests and then I'll be able to send a new patch. Thanks, Sahil
