Re: [PATCH bpf-next v1 1/8] libbpf: allow version suffixes (___smth) for struct_ops types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 28, 2024 at 07:28:49PM +0200, Eduard Zingerman wrote:
> On Wed, 2024-02-28 at 10:29 -0600, David Vernet wrote:
> [...]
> 
> > Modulo the leak pointed out by Kui-Feng in another thread. It would be nice if
> > we could just do this on the stack, but I guess there's no static max size for
> > a tname.
> 
> GCC documents [0] that it does not impose name length limits.
> Skimming through libbpf's btf.c it looks like it does not impose limits either.
> I can add a name buffer and a fallback to strdup logic if tname is too long,
> but I don't think this code would ever be on the hot path.
> 
> [0] https://gcc.gnu.org/onlinedocs/gcc/Identifiers-implementation.html#Identifiers-implementation

Yeah, definitely not worth it. Thanks for looking at the documentation just in
case.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux