Re: [PATCH v1 4/6] perf threads: Move threads to its own files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v1 4/6] perf threads: Move threads to its own files
From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Date: Tue, 27 Feb 2024 16:17:10 -0300
Cc: Ian Rogers <irogers@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Oliver Upton <oliver.upton@xxxxxxxxx>, Yang Jihong <yangjihong1@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx
In-reply-to: <CAM9d7chXtmfaC73ykiwn+RqJmy5jZFWFaV_QNs10c_Td+zmLBQ@mail.gmail.com>

On Tue, Feb 27, 2024 at 09:31:33AM -0800, Namhyung Kim wrote:
> I can see some other differences like machine__findnew_thread()
> which I think is due to the locking change.  Maybe we can fix the
> problem before moving the code and let the code move simple.

I was going to suggest that, agreed.

We may start doing a refactoring, then find a bug, at that point we
first fix the problem them go back to refactoring.

- Arnaldo

Follow-Ups:
- Re: [PATCH v1 4/6] perf threads: Move threads to its own files
  - From: Ian Rogers

References:
- [PATCH v1 0/6] Thread memory improvements and fixes
  - From: Ian Rogers
- [PATCH v1 4/6] perf threads: Move threads to its own files
  - From: Ian Rogers
- Re: [PATCH v1 4/6] perf threads: Move threads to its own files
  - From: Namhyung Kim
- Re: [PATCH v1 4/6] perf threads: Move threads to its own files
  - From: Ian Rogers
- Re: [PATCH v1 4/6] perf threads: Move threads to its own files
  - From: Namhyung Kim

Prev by Date: Re: [PATCH v1 4/6] perf threads: Move threads to its own files
Next by Date: [PATCH bpf-next v1 2/8] libbpf: tie struct_ops programs to kernel BTF ids, not to local ids
Previous by thread: Re: [PATCH v1 4/6] perf threads: Move threads to its own files
Next by thread: Re: [PATCH v1 4/6] perf threads: Move threads to its own files
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SoC] [Linux Rockchip SoC] [Linux Actions SoC] [Linux for Synopsys ARC Processors] [Linux NFS] [Linux NILFS] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]