On Wed, Feb 21, 2024 at 09:35:35AM -0800, Dave Thaler wrote: > * "BPF ADD" should be "BPF_ADD". > * "src" should be "src_reg" in several places. The latter is the field name > in the instruction. The former refers to the value of the register, or the > immediate. > * Add '' around field names in one sentence, for consistency with the rest > of the document. > > Signed-off-by: Dave Thaler <dthaler1968@xxxxxxxxx> Thanks for the cleanup. Acked-by: David Vernet <void@xxxxxxxxxxxxx> > --- > .../bpf/standardization/instruction-set.rst | 72 +++++++++---------- > 1 file changed, 36 insertions(+), 36 deletions(-) > > diff --git a/Documentation/bpf/standardization/instruction-set.rst b/Documentation/bpf/standardization/instruction-set.rst > index 868d9f617..56b5e7dad 100644 > --- a/Documentation/bpf/standardization/instruction-set.rst > +++ b/Documentation/bpf/standardization/instruction-set.rst > @@ -178,7 +178,7 @@ Unused fields shall be cleared to zero. > As discussed below in `64-bit immediate instructions`_, a 64-bit immediate > instruction uses two 32-bit immediate values that are constructed as follows. > The 64 bits following the basic instruction contain a pseudo instruction > -using the same format but with opcode, dst_reg, src_reg, and offset all set to zero, > +using the same format but with 'opcode', 'dst_reg', 'src_reg', and 'offset' all set to zero, > and imm containing the high 32 bits of the immediate value. nit: Can we make sure these columns are all wrapped to 80 characters? This can be done in a follow-up for the whole document later.
Attachment:
signature.asc
Description: PGP signature
