On Tue, 20 Feb 2024 15:18:15 +0100, Halil Pasic <pasic@xxxxxxxxxxxxx> wrote: > On Thu, 1 Feb 2024 11:00:42 +0800 > Xuan Zhuo <xuanzhuo@xxxxxxxxxxxxxxxxx> wrote: > > > > > And squish the parameters from transport to a structure. > > > > > > The patch did more than what is described here, it also switch to use > > > a structure for vring_create_virtqueue() etc. > > > > > > Is it better to split? > > > > Sure. > > I understand there will be a v2. From virtio-ccw perspective I have > no objections. The next version is v1. That is posted. http://lore.kernel.org/all/20240202093951.120283-8-xuanzhuo@xxxxxxxxxxxxxxxxx http://lore.kernel.org/all/20240202093951.120283-9-xuanzhuo@xxxxxxxxxxxxxxxxx Thanks. > > Regards, > Halil