On Fri, 2024-02-16 at 23:02 +0100, Kumar Kartikeya Dwivedi wrote: [...] > > Nit: Maybe move bpf_jit_comp.c:detect_reg_usage() to some place available to > > both verifier and jit? Just to keep all related code in one place. > > E.g. technically nothing prevents x86 jit to do this detection in a more > > precise manner as a "fixed point" computation. > > > > Hm, I remember I did this and then decided against it for some reason, > but I can't remember now. > I will make this change though, if I remember why I didn't go ahead > with it, I will reply again. > > Also, what did you mean by the final sentence? Tried to give some reasoning on why x86 jit implementation might change. On a second thought, not the best reasoning, so please ignore it. My main point here was about duplication of the coupled code: if one would be changed, the other would have to be changed too.
