Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> writes: > From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > Date: Thu, 15 Feb 2024 18:06:42 +0100 > >> Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> writes: >> >>> From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> >>> Date: Thu, 15 Feb 2024 14:26:29 +0100 >>> >>>> Now that we have a system-wide page pool, we can use that for the live >>>> frame mode of BPF_TEST_RUN (used by the XDP traffic generator), and >>>> avoid the cost of creating a separate page pool instance for each >>>> syscall invocation. See the individual patches for more details. >>> >>> Tested xdp-trafficgen on my development tree[0], no regressions from the >>> net-next with my patch which increases live frames PP size. >>> >>> Reviewed-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> >>> Tested-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx> >> >> Great, thanks for taking it for a spin! :) > > BTW, you remove the usage of page_pool->slow.init_callback, maybe we > could remove it completely? Ohh, you're right. Totally forgot that this was something I introduced for this use case :D I'll send a follow-up to get rid of it after this lands. -Toke
