Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> writes: > On 2024-02-13 21:50:51 [+0100], Jesper Dangaard Brouer wrote: >> I generally like the idea around bpf_xdp_storage. >> >> I only skimmed the code, but noticed some extra if-statements (for >> !NULL). I don't think they will make a difference, but I know Toke want >> me to test it... > > I've been looking at the assembly for the return value of > bpf_redirect_info() and there is a NULL pointer check. I hoped it was > obvious to be nun-NULL because it is a static struct. > > Should this become a problem I could add > "__attribute__((returns_nonnull))" to the declaration of the function > which will optimize the NULL check away. If we know the function will never return NULL (I was wondering about that, actually), why have the check in the C code at all? Couldn't we just omit it entirely instead of relying on the compiler to optimise it out? -Toke
