On 02/12, Jiri Olsa wrote:
> On Sat, Feb 10, 2024 at 12:51:21PM +0800, Baoquan He wrote:
> > On 02/09/24 at 11:18am, Stanislav Fomichev wrote:
> > > On 02/09, Hari Bathini wrote:
> > > > With [1], CONFIG_KEXEC & !CONFIG_CRASH_DUMP is supported but that led
> > > > to the below warning:
> > > >
> > > > "WARN: resolve_btfids: unresolved symbol crash_kexec"
> > > >
> > > > Fix it by using the appropriate #ifdef.
> > >
> > > Same question here: how did you find this particular kconfig option
> > > (CONFIG_CRASH_DUMP) to use? Looking at the code, crash_kexec is defined
> > > in kernel/kexec_core.c and it's gated by CONFIG_KEXEC_CORE. So the
> > > existing ifdef seems correct?
> >
> > This patch is based on the latest next tree, I have made some changes to
> > split the crash code from kexec_core.c. If you check next/master branch,
> > crash_kexec is not in kernel/keec_core.c any more.
>
> makes sense, it should have fixes tag:
>
> Fixes: 29fd9ae62910 ("crash: split crash dumping code out from kexec_core.c")
>
> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
+1, would've been nice to have more details in the commit description :-)
Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
