Re: [PATCH v10 net-next 08/15] p4tc: add template pipeline create, get, update, delete

[Jamal Hadi Salim <jhs@xxxxxxxxxxxx>]

On Fri, Feb 9, 2024 at 3:44 PM Marcelo Ricardo Leitner
<mleitner@xxxxxxxxxx> wrote:
>
> On Mon, Jan 22, 2024 at 02:47:54PM -0500, Jamal Hadi Salim wrote:
> > @@ -39,6 +55,27 @@ struct p4tc_template_ops {
> >  struct p4tc_template_common {
> >       char                     name[P4TC_TMPL_NAMSZ];
> >       struct p4tc_template_ops *ops;
> > +     u32                      p_id;
> > +     u32                      PAD0;
>
> Perhaps __pad0 is more common. But, is it really needed?
>

$ pahole -C p4tc_template_common net/sched/p4tc/p4tc_tmpl_api.o
struct p4tc_template_common {
        char                       name[32];             /*     0    32 */
        struct p4tc_template_ops * ops;                  /*    32     8 */
        u32                        p_id;                 /*    40     4 */
        u32                        PAD0;                 /*    44     4 */

        /* size: 48, cachelines: 1, members: 4 */
        /* last cacheline: 48 bytes */
};

Looks good for 64b alignment. We can change the name.

> > +};
>
> Only nit.
>
> Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@xxxxxxxxx>

Thanks for this and all the other reviews. Much appreciated!

cheers,
jamal