On Thu, 8 Feb 2024 18:27:31 -0800 Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > - if (!tb[TCA_ACT_BPF_PARMS]) > > + if (NL_REQ_ATTR_CHECK(extack, nla, tb, TCA_ACT_BPF_PARMS)) { > > + NL_SET_ERR_MSG(extack, "Missing required attribute"); > > Please fix the userspace to support missing attr parsing instead. I was just addressing the error handling. This keeps the same impact as before, i.e no userspace API change.