On Wed, Jan 31, 2024 at 6:57 AM Yafang Shao <laoar.shao@xxxxxxxxx> wrote: > > We should verify the return value of cpumask_success__load(). > > Signed-off-by: Yafang Shao <laoar.shao@xxxxxxxxx> > Cc: David Vernet <void@xxxxxxxxxxxxx> > --- Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > tools/testing/selftests/bpf/prog_tests/cpumask.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/cpumask.c b/tools/testing/selftests/bpf/prog_tests/cpumask.c > index c2e886399e3c..ecf89df78109 100644 > --- a/tools/testing/selftests/bpf/prog_tests/cpumask.c > +++ b/tools/testing/selftests/bpf/prog_tests/cpumask.c > @@ -27,7 +27,7 @@ static void verify_success(const char *prog_name) > struct bpf_program *prog; > struct bpf_link *link = NULL; > pid_t child_pid; > - int status; > + int status, err; > > skel = cpumask_success__open(); > if (!ASSERT_OK_PTR(skel, "cpumask_success__open")) > @@ -36,8 +36,8 @@ static void verify_success(const char *prog_name) > skel->bss->pid = getpid(); > skel->bss->nr_cpus = libbpf_num_possible_cpus(); > > - cpumask_success__load(skel); > - if (!ASSERT_OK_PTR(skel, "cpumask_success__load")) > + err = cpumask_success__load(skel); > + if (!ASSERT_OK(err, "cpumask_success__load")) > goto cleanup; > > prog = bpf_object__find_program_by_name(skel->obj, prog_name); > -- > 2.39.1 >
