On Wed, Jan 24, 2024 at 08:53:49AM -0800, Jakub Kicinski wrote: > On Wed, 24 Jan 2024 13:02:21 +0100 Maciej Fijalkowski wrote: > > > nit: this has just one caller, why not inline these 3 lines? > > > > we usually rely on compiler to do that, we have the rule "no inlines in > > source files", no? > > I mean Ctrl-x Ctrl-v the code, the function has 3 LoC and one caller. > And a semi-meaningless name. I'm not sure why this code was factored > out. Ummm. Probably some previous version was heavier, now I see the point :) Will fix. > > > > nit: prefix the function name, please > > > > will rename to bpf_xdp_shrink_data(). Thanks for taking a look! > > 👍️
