On Sun, Jan 21, 2024 at 11:57 PM Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote: > > insn_is_pseudo_func() will be used in test_verifier, the original idea is > to move it from libbpf.c to libbpf_internal.h and then include the header > to reuse this function, this just adds more internal code of libbpf used > by selftests. While we have allowed it in some cases to avoid duplication > of more complex logic, it is not justified in this case. > > Since insn_is_pseudo_func() and its helper is_ldimm64_insn() are trivial > enough, just copy into testing_helpers. > > Suggested-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> Acked-by: Song Liu <song@xxxxxxxxxx>