Hi, On 1/20/2024 8:35 AM, Sohil Mehta wrote: > On 1/18/2024 11:30 PM, Hou Tao wrote: >> From: Hou Tao <houtao1@xxxxxxxxxx> >> >> Moving is_vsyscall_vaddr() into mm_internal.h to make it available for >> copy_from_kernel_nofault_allowed() in arch/x86/mm/maccess.c. >> > Instead of mm_internal.h would a better place for is_vsyscall_vaddr() be > arch/x86/include/asm/vsyscall.h? Yes, asm/vsyscall.h is better indeed. Will update in v2. Thanks for the suggestion. > > Sohil > > .