Re: [PATCH bpf-next 3/8] bpftool: Fix wrong free call in do_show_link

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 18, 2024 at 5:55 PM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> The error path frees wrong array, it should be ref_ctr_offsets.
>
> Fixes: a7795698f8b6 ("bpftool: Add support to display uprobe_multi links")
> Signed-off-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Acked-by: Yafang Shao <laoar.shao@xxxxxxxxx>

> ---
>  tools/bpf/bpftool/link.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/bpf/bpftool/link.c b/tools/bpf/bpftool/link.c
> index cb46667a6b2e..35b6859dd7c3 100644
> --- a/tools/bpf/bpftool/link.c
> +++ b/tools/bpf/bpftool/link.c
> @@ -977,7 +977,7 @@ static int do_show_link(int fd)
>                         cookies = calloc(count, sizeof(__u64));
>                         if (!cookies) {
>                                 p_err("mem alloc failed");
> -                               free(cookies);
> +                               free(ref_ctr_offsets);
>                                 free(offsets);
>                                 close(fd);
>                                 return -ENOMEM;
> --
> 2.43.0
>


-- 
Regards
Yafang





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux