On 1/16/24 9:29 PM, Victor Stewart wrote:
ammend bpf_redirect_peer header doc to mention tcx and netkit --- include/uapi/linux/bpf.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 754e68ca8..01cc6abe2 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -4839,9 +4839,9 @@ union bpf_attr { * going through the CPU's backlog queue. * * The *flags* argument is reserved and must be 0. The helper is - * currently only supported for tc BPF program types at the ingress - * hook and for veth device types. The peer device must reside in a - * different network namespace. + * currently only supported for tc and tcx BPF program types at the + * ingress hook and for veth and netkit target device types. The peer + * device must reside in a different network namespace. * Return * The helper returns **TC_ACT_REDIRECT** on success or * **TC_ACT_SHOT** on error.
Thanks Victor, I fixed this up a bit, added SoB, and pushed it out (see below link). In general we don't specifically mention tcx program types since it's the same program type as tc BPF (just a different method to attach it). https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=985b8ea9ec7efe6abb6acfc266459e31e9755e6d