On 11/15/19 4:13 PM, Daniel Borkmann wrote: >>> Yeah, only for fd array currently. Question is, if we ever reuse that >>> map_release_uref >>> callback in future for something else, will we remember that we earlier >>> missed to add >>> it here? :/ >> >> What do you mean 'missed to add' ? > > Was saying missed to add the inc/put for the uref counter. > >> This is mmap path. Anything that needs releasing (like FDs for >> prog_array or progs for sockmap) cannot be mmap-able. > > Right, I meant if in future we ever have another use case outside of it > for some reason (unrelated to those maps you mention above). Can we > guarantee this is never going to happen? Seemed less fragile at least to > maintain proper count here. I'm struggling to understand the concern. map-in-map, xskmap, socket local storage are doing bpf_map_inc(, false) when they need to hold the map. Why this case is any different?
