Aoyang Fang (SSE, 222010547) <aoyangfang@xxxxxxxxxxxxxxxx> wrote: > If so, the value of arithmetic instructions’ code should be 4 bit, rather than > BPF_ADD: 0x00, BPF_SUB: 0x10, BPF_MUL: 0x20. Otherwise the convention of > arithmetic instruction is not consistent with the convention of jump > instructions. Good point, you are right that section 3.1 (Arithmetic instructions) and 3.3 (Jump instructions) are not consistent with each other. Since 'code' is defined in section 3 as a 4-bit field, I agree that it would be more consistent to change section 3.1 rather than defining 8-bit values for a 4-bit field. Dave
