> On Thu, Dec 21, 2023 at 11:13:34PM +0100, Jiri Olsa wrote: > > As as side note, I find it's generally a good idea to reset > > attach_tracing_prog in bpf_tracing_prog_attach when the tgt_prog switch > > happens. It has to do both setting it on and off, if the new target is a > > tracing/not tracing prog. The flag still will be kept during the whole > > lifetime, unless switched in bpf_tracing_prog_attach -- meaning no > > changes in bpf_tracing_link_release. If changing the attachment target > > would be possible, that would be the way to go. > > agreed, you can add my ack to the next version with test fix Great, thanks! Will post the new version with updated tests and the same attach_tracing_prog implementation in a moment.
