On Thu, Dec 14, 2023 at 5:14 PM Andrii Nakryiko <andrii@xxxxxxxxxx> wrote:
>
> + } else if (arg->arg_type == (ARG_PTR_TO_DYNPTR | MEM_RDONLY)) {
> + ret = process_dynptr_func(env, regno, -1, arg->arg_type, 0);
Minor nit:
It's a rdonly dynptr, but still... may be pass env->insn_idx instead of -1 ?
Separately, I'm not sure why we still pass insn_idx in so many
functions. Looks like we can use env->insn_idx pretty much everywhere
and remove that argument.
The first 5 patches are very tricky, but all tests are green,
so they must be correct :)
