On Mon, Dec 18, 2023 at 2:39 PM Mina Almasry <almasrymina@xxxxxxxxxx> wrote: > [...] > > > > You didn't address my feedback :| > > > > struct netmem which contains struct page by value is almost as bad > > as passing around pretend struct page pointers. > > Sorry about that. I misread your original request as 'here is > something else you can do if you want', not something that you feel is > critical. Honestly I missed the subtlety and the approaches seemed > roughly equivalent to me. I will respin after the 24hr cooldown. > Jakub's suggestion aligns more with the encoded_page approach as well, so let's proceed with that. Waiting for your respin.
