On Tue, Dec 19, 2023 at 12:26:50PM +0100, Larysa Zaremba wrote:
> On Tue, Dec 19, 2023 at 01:02:05PM +0200, Vladimir Oltean wrote:
> > The ice driver fails to build when CONFIG_XDP_SOCKETS is disabled.
> >
> > drivers/net/ethernet/intel/ice/ice_base.c:533:21: error:
> > variable has incomplete type 'struct xsk_cb_desc'
> > struct xsk_cb_desc desc = {};
> > ^
> > include/net/xsk_buff_pool.h:15:8: note:
> > forward declaration of 'struct xsk_cb_desc'
> > struct xsk_cb_desc;
> > ^
> >
> > Fixes: d68d707dcbbf ("ice: Support XDP hints in AF_XDP ZC mode")
> > Closes: https://lore.kernel.org/netdev/8b76dad3-8847-475b-aa17-613c9c978f7a@xxxxxxxxxxxxx/
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
>
> This probably should go through bpf-next. Other than that, fix looks fine:
>
> Acked-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
>
> > ---
> > Posting to net-next since this tree is broken at this stage, not only
> > bpf-next.
It was a conscious decision. Build fixes are more time critical than
most other patches, and net-next is more likely to suffer from a failure
with CONFIG_XDP_SOCKETS disabled than bpf-next is. But, sure, it's up to
maintainers to figure out how to deal with it.
