On Fri, Dec 15, 2023 at 05:36:21PM +0100, Dmitry Dolgov wrote: > > On Fri, Dec 15, 2023 at 03:48:15PM +0100, Jiri Olsa wrote: > > > + /* Bookkeeping for managing the prog attachment chain */ > > > + if (tgt_prog && > > > + prog->type == BPF_PROG_TYPE_TRACING && > > > + tgt_prog->type == BPF_PROG_TYPE_TRACING) > > > + prog->aux->attach_tracing_prog = true; > > > > hi, > > this still looks bad, I think it should be: > > > > + if (tgt_prog && > > + prog->type == BPF_PROG_TYPE_TRACING && > > + tgt_prog->type == BPF_PROG_TYPE_TRACING) > > + prog->aux->attach_tracing_prog = true; > > > > other than that the patchset looks good to me > > Never thought I would have so many troubles with code formatting :) To > make sure I got it right this time, this is how it should be (with > explicit vim-style tabs and spaces, last tab for "if" predicates is > expanded with spaces), right? right > > +^Iif (tgt_prog && > +^I prog->type == BPF_PROG_TYPE_TRACING && > +^I tgt_prog->type == BPF_PROG_TYPE_TRACING) > +^I^Iprog->aux->attach_tracing_prog = true; yep ;-) > > Thanks for the review and patience. thanks, jirka
