On Fri, Dec 15, 2023 at 2:06 AM Hou Tao <houtao@xxxxxxxxxxxxxxx> wrote: > > From: Hou Tao <houtao1@xxxxxxxxxx> > > Hi, > > The patch set aims to fix the warnings in kvmalloc_node() when passing > an abnormally big cnt during multiple kprobes/uprobes attachment. > > Patch #1 and #2 fix the warning by limiting the maximal number of > uprobes/kprobes. Patch #3, #4, and #5 add tests to ensure these > warnings are fixed. > > Please see individual patches for more details. Comments are always > welcome. > > Change Log: > v3: > * add ack tags from Jiri > * return -E2BIG instead of -EINVAL for too-big cnt (Andrii) > * patch #3: rename the subtest from "failed_link_api" to > "attach_api_fails", so it is consistent with the naming > convention in multi-kprobe test. > * patch #4: newly-added patch to remove libbpf_get_error() in > kprobe_multi_test (Andrii) > > v2: https://lore.kernel.org/bpf/20231213112531.3775079-1-houtao@xxxxxxxxxxxxxxx/ > * limit the number of uprobes/kprobes instead of suppressing the > out-of-memory warning message (Alexei) > * provide a faked non-zero offsets to simplify the multiple uprobe > test (Jiri) > > v1: https://lore.kernel.org/bpf/20231211112843.4147157-1-houtao@xxxxxxxxxxxxxxx/ > > Hou Tao (5): > bpf: Limit the number of uprobes when attaching program to multiple > uprobes > bpf: Limit the number of kprobes when attaching program to multiple > kprobes > selftests/bpf: Add test for abnormal cnt during multi-uprobe > attachment > selftests/bpf: Don't use libbpf_get_error() in kprobe_multi_test > selftests/bpf: Add test for abnormal cnt during multi-kprobe > attachment > > kernel/trace/bpf_trace.c | 7 ++++ > .../bpf/prog_tests/kprobe_multi_test.c | 31 +++++++++++++++--- > .../bpf/prog_tests/uprobe_multi_test.c | 32 ++++++++++++++++++- > 3 files changed, 64 insertions(+), 6 deletions(-) > > -- > 2.29.2 > > LGTM, for the series: Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx>
