Re: [PATCH v2 bpf-next 5/8] libbpf: wire up token_fd into feature probing logic

[Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>]

On Tue, Dec 12, 2023 at 8:00 PM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Tue, Dec 12, 2023 at 10:25:44AM -0800, Andrii Nakryiko wrote:
> >
> > -enum kern_feature_result {
> > -     FEAT_UNKNOWN = 0,
> > -     FEAT_SUPPORTED = 1,
> > -     FEAT_MISSING = 2,
> > -};
> > -
> > -typedef int (*feature_probe_fn)(void);
> > -
> > -struct kern_feature_cache {
> > -     enum kern_feature_result res[__FEAT_CNT];
> > -};
> > +typedef int (*feature_probe_fn)(int /* token_fd */);
>
> Should have been in the previous patch?

This is the first patch that needs to instantiate struct
kern_feature_cache outside of features.c (now also in struct
bpf_object), so I only started needing this change in this patch. But
yep, I can probably place it in a final place in the previous patch
and make it less distracting from the main change. Will adjust in the
next revision.