On Mon, Dec 11, 2023 at 07:49:08PM +0100, Dmitry Dolgov wrote: > > On Mon, Dec 11, 2023 at 01:30:24PM +0100, Jiri Olsa wrote: > > > + /* Bookkeeping for managing the prog attachment chain */ > > > + if (tgt_prog && > > > + prog->type == BPF_PROG_TYPE_TRACING && > > > + tgt_prog->type == BPF_PROG_TYPE_TRACING) > > > + prog->aux->attach_tracing_prog = true; > > > > wrong indentation in here, please check the if conditions around > > I'm a bit confused here, why is the indentation here wrong? IIUC "if" > predicates have to be aligned on the same column, with padding where > needed. Or is it always necessary to expand the last tab with spaces? I meant it should have looked something like this: if (tgt_prog && prog->type == BPF_PROG_TYPE_TRACING && tgt_prog->type == BPF_PROG_TYPE_TRACING) prog->aux->attach_tracing_prog = true; jirka
