Re: [PATCH v1 00/14] Clean up libperf cpumap's empty function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 28, 2023 at 10:02 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Rename and clean up the use of libperf CPU map functions particularly
> focussing on perf_cpu_map__empty that may return true for maps
> containing CPUs but also with an "any CPU"/dummy value.
>
> perf_cpu_map__nr is also troubling in that iterating an empty CPU map
> will yield the "any CPU"/dummy value. Reduce the appearance of some
> calls to this by using the perf_cpu_map__for_each_cpu macro.
>
> Ian Rogers (14):
>   libperf cpumap: Rename perf_cpu_map__dummy_new
>   libperf cpumap: Rename and prefer sysfs for perf_cpu_map__default_new
>   libperf cpumap: Rename perf_cpu_map__empty
>   libperf cpumap: Replace usage of perf_cpu_map__new(NULL)
>   libperf cpumap: Add for_each_cpu that skips the "any CPU" case
>   libperf cpumap: Add any, empty and min helpers
>   perf arm-spe/cs-etm: Directly iterate CPU maps
>   perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty
>     use
>   perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty
>   perf top: Avoid repeated function calls
>   perf arm64 header: Remove unnecessary CPU map get and put
>   perf stat: Remove duplicate cpus_map_matched function
>   perf cpumap: Use perf_cpu_map__for_each_cpu when possible
>   libperf cpumap: Document perf_cpu_map__nr's behavior

Ping. Thanks,
Ian

>  .../perf/Documentation/examples/sampling.c    |  2 +-
>  .../perf/Documentation/libperf-sampling.txt   |  2 +-
>  tools/lib/perf/Documentation/libperf.txt      |  4 +-
>  tools/lib/perf/cpumap.c                       | 92 +++++++++++++------
>  tools/lib/perf/evlist.c                       |  6 +-
>  tools/lib/perf/evsel.c                        |  2 +-
>  tools/lib/perf/include/perf/cpumap.h          | 56 ++++++++++-
>  tools/lib/perf/libperf.map                    | 10 +-
>  tools/lib/perf/tests/test-cpumap.c            |  4 +-
>  tools/lib/perf/tests/test-evlist.c            |  6 +-
>  tools/lib/perf/tests/test-evsel.c             |  2 +-
>  tools/perf/arch/arm/util/cs-etm.c             | 83 +++++++----------
>  tools/perf/arch/arm64/util/arm-spe.c          |  4 +-
>  tools/perf/arch/arm64/util/header.c           | 15 +--
>  tools/perf/arch/x86/util/intel-bts.c          |  4 +-
>  tools/perf/arch/x86/util/intel-pt.c           | 10 +-
>  tools/perf/bench/epoll-ctl.c                  |  2 +-
>  tools/perf/bench/epoll-wait.c                 |  2 +-
>  tools/perf/bench/futex-hash.c                 |  2 +-
>  tools/perf/bench/futex-lock-pi.c              |  2 +-
>  tools/perf/bench/futex-requeue.c              |  2 +-
>  tools/perf/bench/futex-wake-parallel.c        |  2 +-
>  tools/perf/bench/futex-wake.c                 |  2 +-
>  tools/perf/builtin-c2c.c                      |  6 +-
>  tools/perf/builtin-ftrace.c                   |  2 +-
>  tools/perf/builtin-record.c                   |  4 +-
>  tools/perf/builtin-stat.c                     | 31 +------
>  tools/perf/tests/bitmap.c                     | 13 +--
>  tools/perf/tests/code-reading.c               |  2 +-
>  tools/perf/tests/cpumap.c                     |  2 +-
>  tools/perf/tests/keep-tracking.c              |  2 +-
>  tools/perf/tests/mmap-basic.c                 |  2 +-
>  tools/perf/tests/openat-syscall-all-cpus.c    |  2 +-
>  tools/perf/tests/perf-time-to-tsc.c           |  2 +-
>  tools/perf/tests/sw-clock.c                   |  2 +-
>  tools/perf/tests/switch-tracking.c            |  2 +-
>  tools/perf/tests/task-exit.c                  |  2 +-
>  tools/perf/tests/topology.c                   | 48 +++++-----
>  tools/perf/util/auxtrace.c                    |  4 +-
>  tools/perf/util/bpf_counter.c                 |  2 +-
>  tools/perf/util/bpf_kwork.c                   | 16 ++--
>  tools/perf/util/bpf_kwork_top.c               | 12 +--
>  tools/perf/util/cpumap.c                      | 14 ++-
>  tools/perf/util/cputopo.c                     |  2 +-
>  tools/perf/util/evlist.c                      |  4 +-
>  tools/perf/util/evsel.c                       |  2 +-
>  tools/perf/util/perf_api_probe.c              |  4 +-
>  tools/perf/util/record.c                      |  4 +-
>  .../scripting-engines/trace-event-python.c    | 12 ++-
>  tools/perf/util/session.c                     |  5 +-
>  tools/perf/util/stat.c                        |  2 +-
>  tools/perf/util/svghelper.c                   | 20 ++--
>  tools/perf/util/top.c                         |  9 +-
>  53 files changed, 296 insertions(+), 254 deletions(-)
>
> --
> 2.43.0.rc1.413.gea7ed67945-goog
>





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux