Hi Eyal, On Thu, Dec 07, 2023 at 01:08:08PM -0800, Eyal Birger wrote: > Hi Daniel, > > On Thu, Dec 7, 2023 at 3:52 AM Steffen Klassert via Devel > <devel@xxxxxxxxxxxxxxx> wrote: > > > > On Mon, Dec 04, 2023 at 01:56:21PM -0700, Daniel Xu wrote: > > > This commit moves the contents of xfrm_interface_bpf.c into a new file, > > > xfrm_bpf.c This is in preparation for adding more xfrm kfuncs. We'd like > > > to keep all the bpf integrations in a single file. > > This takes away the nice ability to reload the xfrm interface > related kfuncs when reloading the xfrm interface. > > I also find it a little strange that the kfuncs would be available > when the xfrm interface isn't loaded. I think technically since the xfrm interface module does the kfunc registration, the kfuncs would only be available after the module is loaded. > > So imho it makes sense that these kfuncs would be built > as part of the module and not as part of the core. But yeah, point taken. I will revert this commit for v5. > > Eyal. Thanks, Daniel
