On Wed, Dec 06, 2023 at 11:16:12PM +0000, justinstitt@xxxxxxxxxx wrote: > This patch converts some basic cases of ethtool_sprintf() to > ethtool_puts(). > > The conversions are used in cases where ethtool_sprintf() was being used > with just two arguments: > | ethtool_sprintf(&data, buffer[i].name); > or when it's used with format string: "%s" > | ethtool_sprintf(&data, "%s", buffer[i].name); > which both now become: > | ethtool_puts(&data, buffer[i].name); > > Signed-off-by: Justin Stitt <justinstitt@xxxxxxxxxx> > --- > drivers/net/dsa/lantiq_gswip.c | 2 +- > drivers/net/dsa/mt7530.c | 2 +- > drivers/net/dsa/qca/qca8k-common.c | 2 +- > drivers/net/dsa/realtek/rtl8365mb.c | 2 +- > drivers/net/dsa/realtek/rtl8366-core.c | 2 +- > drivers/net/dsa/vitesse-vsc73xx-core.c | 8 +-- > drivers/net/ethernet/amazon/ena/ena_ethtool.c | 4 +- > drivers/net/ethernet/brocade/bna/bnad_ethtool.c | 2 +- > drivers/net/ethernet/freescale/fec_main.c | 4 +- > .../net/ethernet/fungible/funeth/funeth_ethtool.c | 8 +-- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 2 +- > .../net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 2 +- > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 65 +++++++++++----------- > drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 6 +- > drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 3 +- > drivers/net/ethernet/intel/ice/ice_ethtool.c | 9 +-- > drivers/net/ethernet/intel/idpf/idpf_ethtool.c | 2 +- > drivers/net/ethernet/intel/igb/igb_ethtool.c | 6 +- > drivers/net/ethernet/intel/igc/igc_ethtool.c | 6 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 5 +- > .../net/ethernet/microchip/sparx5/sparx5_ethtool.c | 2 +- > .../net/ethernet/netronome/nfp/nfp_net_ethtool.c | 44 +++++++-------- Still happy with the nfp parts, thanks: Reviewed-by: Louis Peens <louis.peens@xxxxxxxxxxxx>