Re: [PATCH bpf v4 0/3] bpf: fix accesses to uninit stack slots

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[...]

Some decorum questions from a newbie:

I'm not sure if this should go to bpf or bpf-next (or perhaps if only the 2nd
patch here should go to bpf and the rest to bpf-next). If anyone has opinions,
I'm happy to re-send or to let whoever applies the patches to choose at
application time. Patch 2 contains a couple of fixes, and there was talk of
backporting... although I'm not sure how bad the bug(s) were in practice.
Patches 1 and 3 don't fix anything, but I'm not sure if it's worth sending them
separately. The first patch doesn't apply cleanly to bpf-next because some
fields were reordered there, but it should be trivial to fixup.

Btw, I also don't know how backporting works, so if I should do anything about
it, please let me know.

The main patch (patch 2) adds some new testing conditions to some existing
tests, and also technically adds a new test (but it's really a subset of an
existing test; the comments there explain). I know that we like to generally
split tests to separate patches (for reasons I'm not sure about), but I don't
know how far to take that rule; not sure if I should apply it here. Will take
guidance.

Thanks!




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux