On Mon, Dec 4, 2023 at 5:45 PM Alexei Starovoitov
<alexei.starovoitov@xxxxxxxxx> wrote:
>
> On Mon, Dec 4, 2023 at 4:23 PM Andrii Nakryiko
> <andrii.nakryiko@xxxxxxxxx> wrote:
> >
> > Alexei, do you remember what was the original intent?
>
> Commit 27113c59b6d0 ("bpf: Check the other end of slot_type for STACK_SPILL")
> introduced is_spilled_reg() and at that time it tried to convert
> all slot_type[0] to slot_type[7] checks.
>
> Looks like this one was simply missed.
ok, so this seems like a correct fix, at least according to original
intent, great
>
> The fixes tag you have:
> Fixes: 638f5b90d460 ("bpf: reduce verifier memory consumption")
> is much older than the introduction of is_spilled_reg.
> At that time everything was checking slot_type[0].
> So this fixes tag is somewhat wrong.
> Probably Fixes: 27113c59b6d0 would be more correct.
yep, will use that, thanks.
