On Fri, Dec 01, 2023 at 05:16:04PM -0700, Daniel Xu wrote: > On Fri, Dec 01, 2023 at 04:10:18PM -0800, Alexei Starovoitov wrote: > > On Fri, Dec 1, 2023 at 12:23 PM Daniel Xu <dxu@xxxxxxxxx> wrote: > > > > > > include/net/xfrm.h | 9 + > > > net/xfrm/Makefile | 1 + > > > net/xfrm/xfrm_policy.c | 2 + > > > net/xfrm/xfrm_state_bpf.c | 128 ++++++++++++++ > > > tools/lib/bpf/bpf_core_read.h | 34 ++++ > > > .../selftests/bpf/prog_tests/test_tunnel.c | 162 +++++++++++++++++- > > > .../selftests/bpf/prog_tests/verifier.c | 2 + > > > tools/testing/selftests/bpf/progs/bpf_misc.h | 1 + > > > .../selftests/bpf/progs/bpf_tracing_net.h | 1 + > > > .../selftests/bpf/progs/test_tunnel_kern.c | 138 ++++++++------- > > > .../bpf/progs/verifier_bitfield_write.c | 100 +++++++++++ > > > tools/testing/selftests/bpf/test_loader.c | 7 + > > > tools/testing/selftests/bpf/test_tunnel.sh | 92 ---------- > > > 13 files changed, 522 insertions(+), 155 deletions(-) > > > > I really think this should go via bpf-next tree. > > The bpf changes are much bigger than ipsec. > > Ack. Ended up picking up a lot of stuff along the way. I'm fine with merging this via the bpf-next tree. Please consider to merge the bpf hepler functions to one file. We have already xfrm_interface_bpf.c and now you introduce xfrm_state_bpf.c. Try to merge this into a single xfrm_bpf.c file.