Jakub Sitnicki wrote: > On Fri, Dec 01, 2023 at 10:24 AM +01, Eric Dumazet wrote: > > On Fri, Dec 1, 2023 at 4:23 AM John Fastabend <john.fastabend@xxxxxxxxx> wrote: > > [...] > > >> diff --git a/include/net/sock.h b/include/net/sock.h > >> index 1d6931caf0c3..ea1155d68f0b 100644 > >> --- a/include/net/sock.h > >> +++ b/include/net/sock.h > >> @@ -2799,6 +2799,11 @@ static inline bool sk_is_tcp(const struct sock *sk) > >> return sk->sk_type == SOCK_STREAM && sk->sk_protocol == IPPROTO_TCP; > >> } > >> > >> +static inline bool sk_is_unix(const struct sock *sk) > > > > Maybe sk_is_stream_unix() ? > > > > +1. I found it confusing as well. > > [...] OK will do v2 with sk_is_stream_unix() so it reads better. Thanks.