On Mon, Nov 11, 2019 at 3:09 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
> On Sun, Nov 10, 2019 at 12:19 AM Daniel T. Lee <danieltimlee@xxxxxxxxx> wrote:
> >
> > Currently, building the bpf samples under samples/bpf directory isn't
> > working. Running make from the directory 'samples/bpf' will just shows
> > following result without compiling any samples.
> >
>
> Do you mind trying to see if it's possible to detect that plain `make`
> is being run from samples/bpf subdirectory, and if that's the case,
> just running something like `make M=samples/bpf -C ../../`? If that's
> not too hard, it would be a nice touch to still have it working old
> (and intuitive) way, IMO.
>
Thanks for the review!
And seems it works with `make M=samples/bpf -C ../../` and it's better
solution!
It's just the issue has been solved as Daniel Borkmann mentioned.
Anyway, thanks for the review!
Best,
Daniel
>
> > $ make
> > make -C ../../ /git/linux/samples/bpf/ BPF_SAMPLES_PATH=/git/linux/samples/bpf
> > make[1]: Entering directory '/git/linux'
> > CALL scripts/checksyscalls.sh
> > CALL scripts/atomic/check-atomics.sh
> > DESCEND objtool
> > make[1]: Leaving directory '/git/linux'
> >
> > Due to commit 394053f4a4b3 ("kbuild: make single targets work more
> > correctly"), building samples/bpf without support of samples/Makefile
> > is unavailable. Instead, building the samples with 'make M=samples/bpf'
> > from the root source directory will solve this issue.[1]
> >
> > This commit fixes the outdated README build command with samples/bpf.
> >
> > [0]: https://patchwork.kernel.org/patch/11168393/
> >
> > Signed-off-by: Daniel T. Lee <danieltimlee@xxxxxxxxx>
> > ---
> > samples/bpf/README.rst | 19 +++++++++----------
> > 1 file changed, 9 insertions(+), 10 deletions(-)
> >
>
> [...]
