Re: [PATCH bpf-next v3 0/2] Allow data_meta size > 32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 28, 2023 at 11:26:59AM +0100, Jesper Dangaard Brouer wrote:
> 
> 
> On 11/27/23 19:32, Larysa Zaremba wrote:
> > Currently, there is no reason for data_meta to be limited to 32 bytes.
> > Loosen this limitation and make maximum meta size 252.
> 
> First I though you made a type here with 252 bytes, but then I remembered
> the 4 byte alignment.
> I think commit message should elaborate on why 252 bytes.
>

You are right, will do.
 
> > 
> > Also, modify the selftest, so test_xdp_context_error does not complain
> > about the unexpected success.
> > 
> > v2->v3:
> > * Fix main patch author
> > * Add selftests path
> > 
> > v1->v2:
> > * replace 'typeof(metalen)' with the actual type
> > 
> > Aleksander Lobakin (1):
> >    net, xdp: allow metadata > 32
> > 
> > Larysa Zaremba (1):
> >    selftests/bpf: increase invalid metadata size
> > 
> >   include/linux/skbuff.h                              | 13 ++++++++-----
> >   include/net/xdp.h                                   |  7 ++++++-
> >   .../selftests/bpf/prog_tests/xdp_context_test_run.c |  4 ++--
> >   3 files changed, 16 insertions(+), 8 deletions(-)
> > 




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux