On Mon, Nov 27, 2023 at 8:23 PM Eduard Zingerman <eddyz87@xxxxxxxxx> wrote: > > On Sat, 2023-11-25 at 20:50 -0500, Andrei Matei wrote: > > This patch adds tests for the previous patch, checking the tracking of > > the maximum stack size and checking that accesses to uninit stack memory > > are allowed. > > > > They are a separate patch for review purposes; whoever merges them can > > consider squashing. > > > > Signed-off-by: Andrei Matei <andreimatei1@xxxxxxxxx> > > --- > > I think the strategy now is to add new tests using inline assembly, > e.g. as a part of verifier_* tests in test_progs. Thanks, I'll try that. I see in some of the verifier tests that you have converted to test_progs hints that they were converted "automatically". I'm curious what tool you've used, if any. Do you have any thoughts on how a test could assert the maximum stack depth? test_verifier has access to the verifier verifier log and parses it out of there; do you know how I could achieve the same in test_progs? For the curiosity of someone who doesn't know much about this code base - how come we moved from test_verifier, which seems a bit more unit-test-y, do the higher level test_progs? Is it because of the nicer assembly syntax?
