On Mon, 27 Nov 2023 at 18:21, Stanislav Fomichev <sdf@xxxxxxxxxx> wrote:
>
> Commit ef01f4e25c17 ("bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD
> and PERF_BPF_EVENT_PROG_UNLOAD") stopped removing program's id from
> idr when the offloaded/bound netdev goes away. I was supposed to
> take a look and check in [0], but apparently I did not.
>
> Martin points out it might be useful to keep it that way for
> observability sake, but we at least need to mark those programs as
> unusable.
>
> Mark those programs as 'orphaned' and keep printing the list when
> we encounter ENODEV.
>
> 0: unspec tag 0000000000000000
> xlated 0B not jited memlock 4096B orphaned
>
> [0]: https://lore.kernel.org/all/CAKH8qBtyR20ZWAc11z1-6pGb3Hd47AQUTbE_cfoktG59TqaJ7Q@xxxxxxxxxxxxxx/
>
> v3:
> * use two spaces for " orphaned" (Quentin)
>
> Cc: netdev@xxxxxxxxxxxxxxx
> Fixes: ef01f4e25c17 ("bpf: restore the ebpf program ID for BPF_AUDIT_UNLOAD and PERF_BPF_EVENT_PROG_UNLOAD")
> Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxx>
Reviewed-by: Quentin Monnet <quentin@xxxxxxxxxxxxx>
Thanks!
