On Fri, Nov 24, 2023 at 11:42:30AM -0800, Andrew Morton wrote: > On Thu, 23 Nov 2023 10:19:42 +0300 Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxxxxx> wrote: > > > To begin with, this patch series relocates the cgroup example code to > > the samples/cgroup directory, which is the appropriate location for such > > code snippets. > > butbut. Didn't we decide to do s/cgroup/memcg/ throughout? I believe the samples directory should be named "samples/cgroup" instead of "memcg" because the cgroup v1 event listener cannot be renamed to "memcg" due to the common naming of cgroup v1 event_control (this sample uses that control to access eventfd). Additionally, I think it would be a good idea to add the new samples for cgroup helpers in that directory. That's why I have only renamed the new memcg listener. -- Thank you, Dmitry
