2023-11-16 19:43 UTC+0000 ~ Manu Bretelle <chantr4@xxxxxxxxx> > Signed-off-by: Manu Bretelle <chantr4@xxxxxxxxx> I'd keep at least the command to invoke the test in the commit description, in case someone only looks at this commit log and wonders how to launch the test. Also this test is not supposed to succeed with all versions of bpftool (we need support for skeletons in bpftool for dumping the PIDs). So I'd like to have either 1) a check on "bpftool version" to make sure that the required feature is present, and skip the test otherwise, or 2) an option in the Cargo.toml to enforce or skip this test. >From what I understand, you're using this test to make sure that PIDs are present, to avoid relying on the output from "bpftool version" only; so maybe option 2 makes more sense, a parameter to tell cargo to run the test and expect the PIDs to be present, whatever "bpftool version" says? Quentin
