On Mon, 2023-11-20 at 17:00 -0800, Andrii Nakryiko wrote:
[...]
> > diff --git a/include/linux/bpf_verifier.h b/include/linux/bpf_verifier.h
> > index 24213a99cc79..6e21d74a64e7 100644
> > --- a/include/linux/bpf_verifier.h
> > +++ b/include/linux/bpf_verifier.h
> > @@ -400,6 +400,7 @@ struct bpf_verifier_state {
> > struct bpf_idx_pair *jmp_history;
> > u32 jmp_history_cnt;
> > u32 dfs_depth;
> > + u32 cumulative_callback_depth;
>
> nit: depth and cumulative in this case doesn't make much sense to me,
> tbh. Cumulative is generally a sum of something. You don't seem to
> ever decrement this, so I guess "max_callback_depth" or
> "cur_callback_depth" would also make sense? "callback_unroll_depth" is
> another name that came to mind. But it's honestly not that important
> to me, the use of this field is very minimal in the code base.
Will use 'callback_unroll_depth' in v4, thanks.
