Re: [PATCH bpf-next v5 2/2] selftests: bpf: crypto skcipher algo selftests

[Vadim Fedorenko <vadim.fedorenko@xxxxxxxxx>]

On 19.11.2023 21:58, Alexei Starovoitov wrote:
> On Sat, Nov 18, 2023 at 2:55 PM Vadim Fedorenko <vadfed@xxxxxxxx> wrote:
> > +
> > +SEC("fentry.s/bpf_fentry_test1")
> > +int BPF_PROG(skb_crypto_setup)
> > +{
> > +       struct bpf_crypto_lskcipher_ctx *cctx;
> > +       struct bpf_dynptr key = {};
> > +       int err = 0;
> > +
> > +       status = 0;
> > +
> > +       bpf_dynptr_from_mem(crypto_key, sizeof(crypto_key), 0, &key);
> > +       cctx = bpf_crypto_lskcipher_ctx_create(crypto_algo, &key, &err);
>
> Direct string will work here, right?
> What's the reason to use global var?

Mmm, yeah, should work. I'll update the test, thanks!