Re: [PATCH v2 bpf-next 10/13] selftests/bpf: add randomized reg_bounds tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 11, 2023 at 5:06 PM Andrii Nakryiko <andrii@xxxxxxxxxx> wrote:
>
> +/* [RANDOM] RANGE x RANGE, U64 initial range */
> +void test_reg_bounds_rand_ranges_u64_u64(void) { validate_rand_ranges(U64, U64, false /* range */); }


All is great, but after seeing the lines scroll by so fast and so much
it feels like spam.

Could you reduce the verbosity and print "OK" once per test
instead of every random constant?

Like the following:
240/266 reg_bounds_rand_consts_u64_u64/(u64)[0x385e7e5eadec2778;
0x82047f51ee240764] (u64)<= 0x4213de45972c52b:OK
#240/267 reg_bounds_rand_consts_u64_u64/(u64)[0x385e7e5eadec2778;
0x82047f51ee240764] (u64)> 0x4213de45972c52b:OK
#240/268 reg_bounds_rand_consts_u64_u64/(u64)[0x385e7e5eadec2778;
0x82047f51ee240764] (u64)>= 0x4213de45972c52b:OK
#240/269 reg_bounds_rand_consts_u64_u64/(u64)[0x385e7e5eadec2778;
0x82047f51ee240764] (u64)== 0x4213de45972c52b:OK
#240/270 reg_bounds_rand_consts_u64_u64/(u64)[0x385e7e5eadec2778;
0x82047f51ee240764] (u64)!= 0x4213de45972c52b:OK
#240/271 reg_bounds_rand_consts_u64_u64/(u64)0x4213de45972c52b (u64)<
[0x385e7e5eadec2778; 0x82047f51ee240764]:OK
#240/272 reg_bounds_rand_consts_u64_u64/(u64)0x4213de45972c52b (u64)<=
[0x385e7e5eadec2778; 0x82047f51ee240764]:OK
#240/273 reg_bounds_rand_consts_u64_u64/(u64)0x4213de45972c52b (u64)>
[0x385e7e5eadec2778; 0x82047f51ee240764]:OK
#240/274 reg_bounds_rand_consts_u64_u64/(u64)0x4213de45972c52b (u64)>=
[0x385e7e5eadec2778; 0x82047f51ee240764]:OK
#240/275 reg_bounds_rand_consts_u64_u64/(u64)0x4213de45972c52b (u64)==
[0x385e7e5eadec2778; 0x82047f51ee240764]:OK

isn't that helpful to see every time.





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux