Re: [PATCH net-next v8 15/15] p4tc: Add P4 extern interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thu, Nov 16, 2023 at 03:59:48PM CET, jhs@xxxxxxxxxxxx wrote:

[...]

> include/net/p4tc.h                |  161 +++
> include/net/p4tc_ext_api.h        |  199 +++
> include/uapi/linux/p4tc.h         |   61 +
> include/uapi/linux/p4tc_ext.h     |   36 +
> net/sched/p4tc/Makefile           |    2 +-
> net/sched/p4tc/p4tc_bpf.c         |   79 +-
> net/sched/p4tc/p4tc_ext.c         | 2204 ++++++++++++++++++++++++++++
> net/sched/p4tc/p4tc_pipeline.c    |   34 +-
> net/sched/p4tc/p4tc_runtime_api.c |   10 +-
> net/sched/p4tc/p4tc_table.c       |   57 +-
> net/sched/p4tc/p4tc_tbl_entry.c   |   25 +-
> net/sched/p4tc/p4tc_tmpl_api.c    |    4 +
> net/sched/p4tc/p4tc_tmpl_ext.c    | 2221 +++++++++++++++++++++++++++++
> 13 files changed, 5083 insertions(+), 10 deletions(-)

This is for this patch. Now for the whole patchset you have:
 30 files changed, 16676 insertions(+), 39 deletions(-)

I understand that you want to fit into 15 patches with all the work.
But sorry, patches like this are unreviewable. My suggestion is to split
the patchset into multiple ones including smaller patches and allow
people to digest this. I don't believe that anyone can seriously stand
to review a patch with more than 200 lines changes.

[...]




[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux