On Fri, Nov 8, 2019 at 1:33 PM Toke Høiland-Jørgensen <toke@xxxxxxxxxx> wrote: > > From: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > > This adds a new getter for the BPF program size (in bytes). This is useful > for a caller that is trying to predict how much memory will be locked by > loading a BPF object into the kernel. > > Acked-by: Song Liu <songliubraving@xxxxxx> > Signed-off-by: Toke Høiland-Jørgensen <toke@xxxxxxxxxx> > --- Can you add comment mentioning that this is size in bytes, not in number of instructions? It's certainly will be a first question anyone using this will ask. I think it's good to have this, but I don't think you can really predict how much memory will be used. I'd expect memory used by maps (and not just based on element size and count, but some internal bookkeeping stuff) would be much bigger factor and not easy to guess. So beyond just stats dumping, I think this won't be that helpful. Acked-by: Andrii Nakryiko <andriin@xxxxxx> > tools/lib/bpf/libbpf.c | 5 +++++ > tools/lib/bpf/libbpf.h | 1 + > tools/lib/bpf/libbpf.map | 1 + > 3 files changed, 7 insertions(+) > [...]
