Re: [PATCH v3 bpf-next 13/18] bpf: Fix race in btf_resolve_helper_id()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 7, 2019 at 10:42 PM Alexei Starovoitov <ast@xxxxxxxxxx> wrote:
>
> btf_resolve_helper_id() caching logic is a bit racy, since under root the
> verifier can verify several programs in parallel. Fix it with READ/WRITE_ONCE.
> Fix the type as well, since error is also recorded.
>
> Fixes: a7658e1a4164 ("bpf: Check types of arguments passed into helpers")
> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> ---

looks good

Acked-by: Andrii Nakryiko <andriin@xxxxxx>

>  include/linux/bpf.h   |  5 +++--
>  kernel/bpf/btf.c      | 26 +++++++++++++++++++++++++-
>  kernel/bpf/verifier.c |  8 +++-----
>  net/core/filter.c     |  2 +-
>  4 files changed, 32 insertions(+), 9 deletions(-)
>

[...]



[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux