Re: [PATCH bpf 4/6] bpf, netkit: Add indirect call wrapper for fetching peer dev

[Daniel Borkmann <daniel@xxxxxxxxxxxxx>]

On 11/6/23 6:21 PM, Stanislav Fomichev wrote:
[...]
> > +static struct net_device *skb_get_peer_dev(struct net_device *dev)
> > +{
> > +	const struct net_device_ops *ops = dev->netdev_ops;
> > +
> > +	if (likely(ops->ndo_get_peer_dev))
> > +		return INDIRECT_CALL_1(ops->ndo_get_peer_dev,
> > +				       netkit_peer_dev, dev);
>
> nit: why not put both netkit and veth here under INDIRECT_CALL_2 ?
> Presumably should help with the veth deployments as well?

Yes, I'm also planning to add it there as well, it's a slightly larger
change since also a new header needs to be added, but I'll follow-up on it.

Thanks for review,
Daniel