Re: [PATCH v6 bpf-next 3/9] bpf: Introduce KF_ARG_PTR_TO_CONST_STR

[Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>]

On Tue, Oct 24, 2023 at 4:56 PM Song Liu <song@xxxxxxxxxx> wrote:
>
>
> +2.2.5 __const_str Annotation
> +----------------------------
> +This annotation is used to indicate that the argument is a constant string.
> +
> +An example is given below::
> +
> +        __bpf_kfunc bpf_get_file_xattr(..., const char *name__const_str, ...)

After sleeping on it this still looks too verbose to me.
'const' is repeated back to back.
Let's use __str suffix?

> +                       ret = check_reg_const_str(env, reg, regno);

I don't mind that helper has a more verbose name.