On Fri, Oct 27, 2023 at 01:09:30PM -0700, Jakub Kicinski wrote: > On Thu, 26 Oct 2023 18:56:59 +0200 Larysa Zaremba wrote: > > static inline bool xdp_metalen_invalid(unsigned long metalen) > > { > > - return (metalen & (sizeof(__u32) - 1)) || (metalen > 32); > > + typeof(metalen) meta_max; > > The use of typeof() looks a bit unnecessary.. > You are probably right, will send v2 without it.